-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
huijie - schedule meeting bell notification #1154
base: development
Are you sure you want to change the base?
huijie - schedule meeting bell notification #1154
Conversation
552c36f
to
4955236
Compare
everything worked as expected, review left on #2878 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am having trouble selecting participants to schedule the meeting with. it's not letting me select the participant even if I type in the full name, therefore I am unable to test whether or not the notification is sent out. I'm not sure why this is happening. If I double click it selects the person and then quickly deselects him, when clicking once nothing happens. I tried this out in multiple browsers and in private mode and this front end issue still persists.
Description
Related PRS (if any):
This backend PR is related to the #2878 frontend PR(OneCommunityGlobal/HighestGoodNetworkApp#2878).
Main changes explained:
Known bugs:
The bell does not ring for the first meeting notification displayed but rings for subsequent ones. This happens because browsers block the autoplay of audio or video until the user interacts with the page (e.g., by clicking or tapping). A possible solution could be to display a preview notification for the upcoming meeting, prompting the user to click a button on the page, which would then allow the bell to ring for future notifications.
How to test:
npm install
andnpm run start:local
to run this PR locallyScreenshots or videos of changes: